Codechange: remove C-style memory management #13639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
OpenTTD has been a C++ application for years and most code is using C++ memory management, except a few stragglers.
These stragglers are anything using
MallocT
,CallocT
,ReallocT
and most uses offree
except when data is coming from external APIs.Description
Implemented:
ReallocT
for dirty blocksMallocT
for ParagraphLayouter's buffermalloc
byScriptAllocator
MallocT
/CallocT
by poolZeroedMemoryAllocator
byWindow
MallocT
bySimpleSpriteAllocator
; used in OpenGL and unit testLimitations
Waiting for the PRs to get merged before the includes and unused code can finally be actually removed.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.