Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bump Decidim Awesome module #95

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

luciegrau
Copy link
Contributor

🎩 Description

Please describe your pull request.
Bump of the Decidim Awesome module to have the correct french translations for private proposal fields feature.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

  • Log in as admin
  • Access Backoffice
  • Go to Decidim Awesome > Custom proposal fields
  • Check if you have no translation missing in french

Copy link
Contributor

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The French translation is indeed present everywhere on Decidim Awesome 👍

@Stef-Rousset
Copy link
Contributor

Stef-Rousset commented Aug 23, 2024

No missing translations so far, but when I try to "Ajouter une nouvelle boîte de champs personnalisés", or when I try to "Ajouter une nouvelle section de champs personnalisés", I have an error in console (screenshot below) and something doesn't load
Capture d’écran 2024-08-23 à 16 49 17

Stef-Rousset
Stef-Rousset previously approved these changes Aug 26, 2024
@Stef-Rousset Stef-Rousset dismissed their stale review August 26, 2024 09:53

error of approval

Copy link
Member

@moustachu moustachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JS error doesn't seems to be blocking.
Let's give it a try and remember that there was this thing if we detect something in the long run.

@luciegrau luciegrau merged commit e6de726 into develop Aug 29, 2024
14 checks passed
@luciegrau luciegrau deleted the bump-decidim_awesome branch August 29, 2024 11:01
moustachu pushed a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants