Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Préparation IH #26

Merged
merged 17 commits into from
May 5, 2023
Merged

Préparation IH #26

merged 17 commits into from
May 5, 2023

Conversation

eliegaboriau
Copy link
Contributor

@eliegaboriau eliegaboriau commented May 2, 2023 •
edited
Loading

This PR updates the CI/CD and the admin creation

@eliegaboriau eliegaboriau changed the title Add admin creation task Préparation IH May 2, 2023
@eliegaboriau eliegaboriau marked this pull request as ready for review May 2, 2023 16:13
armandfardeau
armandfardeau requested changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@armandfardeau armandfardeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello thanks for your contribution !

Could you please fix the failing CI workflow?

@eliegaboriau eliegaboriau requested review from armandfardeau and a team May 3, 2023 08:00
Quentinchampenois
Quentinchampenois requested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use specific CD, we should define a new inventory

.github/workflows/deploy_production.yml Outdated Show resolved Hide resolved
@Quentinchampenois Quentinchampenois removed the request for review from paulinebessoles May 5, 2023 07:53
@eliegaboriau eliegaboriau requested review from Quentinchampenois and a team May 5, 2023 08:45
@Quentinchampenois
Copy link
Contributor

I removed CD for production

@armandfardeau
Copy link
Collaborator

Hello thanks for your contribution !

CI-CD has been updated, take a look at decidim-app

I've switched this P.R. to draft, feel free to request a review when everything is in order

@armandfardeau armandfardeau marked this pull request as draft May 5, 2023 10:36
@eliegaboriau eliegaboriau marked this pull request as ready for review May 5, 2023 11:39
@eliegaboriau eliegaboriau requested a review from a team May 5, 2023 11:39
@eliegaboriau eliegaboriau merged commit 72e04a5 into develop May 5, 2023
@eliegaboriau eliegaboriau deleted the add/admin_creation_task branch May 5, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armandfardeau armandfardeau armandfardeau approved these changes

@Quentinchampenois Quentinchampenois Quentinchampenois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliegaboriau @Quentinchampenois @armandfardeau