Add integrity and defer to assets #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armandfardeau
requested review from
a team and
paulinebessoles
and removed request for
a team
|
Thanks @armandfardeau ! Could you check failing test please? |
|
Was looking at it on another PR this the failing tests were not introduced by this. |
paulinebessoles
approved these changes
Nov 10, 2021
Quentinchampenois
approved these changes
Nov 22, 2021
paulinebessoles
added a commit
that referenced
this pull request
Nov 29, 2021
* Bump to 0.24 * Fix tests * Fix ruby version in tests * Linting files * Backport fix/user answers serializer (#11) * Add specs for user answers serializer * Backport lib user_answers_serializer * Fix meetings registration serializer * Generate Overrides md file * Fix application db initialization * Linting files * Fix application db initialization * Delete unused overload * Fix tests * Lint code and update tests * Fix failing tests * Fix conflicts and fix job specs * Add machine translation job * Remove decidim-cookies config * Remove .rspec-failures file * Linting files * add backup tasks + new job scheduling * fix rubocop offenses * fix rubocop offenses * fix rubocop offenses * Add logs on Deepl translation (#13) * Add previously removed job * Rescue error on deepl translator * Fix rubocop offenses * Update meetings order overloads (#15) * Delete meetings_controller * Update Overload file * Remove unused keys * Add updated overloads * Update overloads * Remove unused and missing keys * Add meetings indexes tests * Update translations * Add integrity and defer to assets (#14) * Add integrity and defer to assets * Remove defer attributes * Fix empty line Co-authored-by: moustachu <[email protected]> * Update asset host * Add and fix broken factory Co-authored-by: MoretS <[email protected]> Co-authored-by: quentinchampenois <[email protected]> Co-authored-by: moustachu <[email protected]> Co-authored-by: paulinebessoles <[email protected]> Co-authored-by: Pauline Bessoles <[email protected]> Co-authored-by: Armand Fardeau <[email protected]>
Quentinchampenois
added a commit
that referenced
this pull request
Mar 10, 2022
* Bump to 0.24 * Fix tests * Fix ruby version in tests * Linting files * Backport fix/user answers serializer (#11) * Add specs for user answers serializer * Backport lib user_answers_serializer * Fix meetings registration serializer * Generate Overrides md file * Fix application db initialization * Linting files * Fix application db initialization * Delete unused overload * Fix tests * Lint code and update tests * Fix failing tests * Fix conflicts and fix job specs * Add machine translation job * Remove decidim-cookies config * Remove .rspec-failures file * Linting files * add backup tasks + new job scheduling * fix rubocop offenses * fix rubocop offenses * fix rubocop offenses * Add logs on Deepl translation (#13) * Add previously removed job * Rescue error on deepl translator * Fix rubocop offenses * Update meetings order overloads (#15) * Delete meetings_controller * Update Overload file * Remove unused keys * Add updated overloads * Update overloads * Remove unused and missing keys * Add meetings indexes tests * Update translations * Add integrity and defer to assets (#14) * Add integrity and defer to assets * Remove defer attributes * Fix empty line Co-authored-by: moustachu <[email protected]> * Update asset host * Add and fix broken factory * Update database.yml * Update carrierwave.rb * Update secrets.yml * Update sidekiq.yml * Update http headers (#16) * Update HTTP Headers * Fix rubocop offenses * Backport fix geocoded proposals and permissions (#17) * Add proposals controller specs * Add proposal controller * Fix geocoding and permissions * ignore missing keys * Fix rubocop offenses * Add overloads Co-authored-by: MoretS <[email protected]> Co-authored-by: quentinchampenois <[email protected]> Co-authored-by: moustachu <[email protected]> Co-authored-by: Sébastien Moret <[email protected]> Co-authored-by: Armand Fardeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.