Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimize local docker build #554

Merged
merged 5 commits into from
Jul 2, 2024
Merged

feat: Optimize local docker build #554

merged 5 commits into from
Jul 2, 2024

Conversation

Quentinchampenois
Copy link
Contributor

@Quentinchampenois Quentinchampenois commented Jun 7, 2024 •
edited
Loading

🎩 Description

Please describe your pull request.

Rewrite local Docker configuration

  • Speed up container creation using make run
  • Allow to expose Docker container on local network using make external

How to test :

Local app

On local network

  • Run make external
  • Access : https://[IP]:3000

⚠️ This configuration does not change production configuration

@Quentinchampenois Quentinchampenois marked this pull request as ready for review June 18, 2024 10:00
moustachu
moustachu previously approved these changes Jun 18, 2024
View reviewed changes
Stef-Rousset
Stef-Rousset previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Stef-Rousset Stef-Rousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both run and external, and it works fine !

luciegrau
luciegrau previously approved these changes Jun 18, 2024
View reviewed changes
@Quentinchampenois Quentinchampenois added the release: v2.3 Candidate for 2.3.0 release label Jun 19, 2024
@luciegrau luciegrau self-requested a review July 1, 2024 09:54
@luciegrau luciegrau added type: enhancement Issues or PRs that enhance an existing feature priority: low status: ready for staging Can be tested on a staging environment labels Jul 1, 2024
Stef-Rousset
Stef-Rousset approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Stef-Rousset Stef-Rousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested make run and make eternal and it still works great !

@luciegrau luciegrau merged commit 4b02210 into develop Jul 2, 2024
14 checks passed
@luciegrau luciegrau mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef-Rousset Stef-Rousset Stef-Rousset approved these changes

@luciegrau luciegrau luciegrau approved these changes

@BarbaraOliveira13 BarbaraOliveira13 Awaiting requested review from BarbaraOliveira13

@moustachu moustachu Awaiting requested review from moustachu

Assignees
No one assigned
Labels
priority: low release: v2.3 Candidate for 2.3.0 release status: ready for staging Can be tested on a staging environment type: enhancement Issues or PRs that enhance an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quentinchampenois @moustachu @Stef-Rousset @luciegrau