Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposals map async list #552

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

Stef-Rousset
Copy link
Contributor

🎩 Description

In Assembles > proposals, when changing the filters, the markers on the map are not updated.

📌 Related Issues

Testing

  1. As a user, go to Assemblies, choose one assembly and go to proposals
  2. Note that the number of markers on the map matches the number of proposals (cf screenshot one)
  3. In the filters, deselect for example one category.
  4. Note that the number of markers on the map is updated and matches the updated number of proposals (cf screenshot two)

📷 Screenshots

screenshot one =>
Capture d’écran 2024-06-05 à 14 54 40

screenshot two =>
Capture d’écran 2024-06-05 à 14 56 22

@Stef-Rousset Stef-Rousset changed the title Fix/proposals map async list Fix proposals map async list Jun 5, 2024
@Stef-Rousset Stef-Rousset marked this pull request as ready for review June 5, 2024 13:54
Copy link
Contributor

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Ran It, works 🎉

Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce 👍

@Quentinchampenois Quentinchampenois merged commit ddbbf71 into develop Jun 18, 2024
14 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/proposals_map_async_list branch June 18, 2024 09:02
@luciegrau luciegrau mentioned this pull request Jun 19, 2024
Quentinchampenois added a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants