Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Module anonymous proposals #527

Merged
merged 8 commits into from
Jul 2, 2024

Conversation

Quentinchampenois
Copy link
Contributor

@Quentinchampenois Quentinchampenois commented May 2, 2024

🎩 Description

This PR adds anonymous proposals dependencies to the application. The version used is compatible with 0.27 Decidim release (there is another branch with the code adapted to 0.28)

After deploying the code additional steps should be done to check the functionality:

The PR basically adds the dependency into the Gemfile. The next steps to make work the module are:

  • Run the decidim_anonymous_proposals:generate_anonymous_group task to create an anonymous group to associate the proposals with
  • Ensure that the DEFACE_ENABLED environment variable is set as true to allow the module to overwrite the forms and create new proposal button

📌 Related Issues

  • Related to PopulateTools/issues#1894

Testing

After doing the previous steps of the description:

  • Log in as admin
  • Access Backoffice
  • Go to an existing proposals component or create a new one and enable from its settings the creation of anonymous proposals and also allow participants to create proposals

Duplicate of #517

Author: @entantoencuanto

@Quentinchampenois Quentinchampenois marked this pull request as ready for review May 16, 2024 13:10
@Quentinchampenois Quentinchampenois changed the title Install anonymous proposals feat: Module anonymous proposals May 16, 2024
Stef-Rousset
Stef-Rousset previously approved these changes May 17, 2024
Copy link
Contributor

@Stef-Rousset Stef-Rousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as described in PR !

@luciegrau
Copy link
Collaborator

⚠️ PLEASE DO NOT MERGE THIS PR, IT WILL BE INCLUDED IN OUR NEXT RELEASE ! 😁

@Quentinchampenois Quentinchampenois marked this pull request as draft May 17, 2024 16:11
@Quentinchampenois Quentinchampenois marked this pull request as ready for review May 17, 2024 16:12
@luciegrau luciegrau added release: v2.3 Candidate for 2.3.0 release type: module PRs that add a new module labels May 17, 2024
@luciegrau luciegrau added status: ready for staging Can be tested on a staging environment status: testing priority: medium and removed status: ready for staging Can be tested on a staging environment labels May 21, 2024
@simonaszilinskas
Copy link
Contributor

Tested thoroughly, adding some videos of the tests.

Minor problems:

  • when admins or users write a message to the anonymous group, all people in it receive it (very minor problem)
  • couldn't submit a comment, but I think this is a problem with my env
recette1-anonymous.mp4
recette2-anonymous.mp4

luciegrau
luciegrau previously approved these changes Jul 1, 2024
@Quentinchampenois Quentinchampenois merged commit 3fc3f90 into develop Jul 2, 2024
14 checks passed
@Quentinchampenois Quentinchampenois deleted the install_anonymous_proposals branch July 2, 2024 09:50
@luciegrau luciegrau mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium release: v2.3 Candidate for 2.3.0 release status: testing type: module PRs that add a new module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants