Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:bump friendly signup #524

Merged
merged 1 commit into from
May 2, 2024
Merged

fix:bump friendly signup #524

merged 1 commit into from
May 2, 2024

Conversation

BarbaraOliveira13
Copy link
Contributor

🎩 Description

Bump *friendly_signup: with button disabled when the user enters the registration code.
*This module simply substitutes some pages to ease up the registration process in Decidim.

📌 Related Issues
Link your PR to an issue

Related to #?
Fixes #?
Notion card

Testing

  1. Go to sign up
  2. Enter the registration code received by mail (The 'verify' button has become disabled)
  3. It should automatically display your homepage

Tasks

  • Add specs
  • Add note about overrides in OVERLOADS.md
  • In case of new dependencies or version bump, update related documentation

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.65%. Comparing base (bd14241) to head (46ebca5).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #524      +/-   ##
===========================================
- Coverage    89.51%   88.65%   -0.87%     
===========================================
  Files           68       68              
  Lines         1622     1622              
===========================================
- Hits          1452     1438      -14     
- Misses         170      184      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois marked this pull request as ready for review May 2, 2024 11:15
Copy link
Collaborator

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@luciegrau luciegrau merged commit c61a173 into develop May 2, 2024
15 of 16 checks passed
@luciegrau luciegrau deleted the fix_bump_friendly_signup branch May 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants