Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/budgets projects searchable #521

Merged
merged 6 commits into from
May 2, 2024

Conversation

BarbaraOliveira13
Copy link
Contributor

🎩 Description

Backport #12017 fix:projects displayed in search when not published

📌 Related Issues

Link your PR to an issue

Testing

  1. Duplicate a seed process (unpublished)
  2. Go to new process components
  3. Create a budget
  4. Create a project
  5. In private browsing, see that the project is displayed in search for visitors, even though the process and the budget component are unpublished

Tasks

  • Add specs
  • Add note about overrides in OVERLOADS.md
  • In case of new dependencies or version bump, update related documentation

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (bd14241) to head (ea19cfd).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
- Coverage    89.51%   89.11%   -0.41%     
===========================================
  Files           68       68              
  Lines         1622     1626       +4     
===========================================
- Hits          1452     1449       -3     
- Misses         170      177       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as ready for review April 30, 2024 14:15
@Quentinchampenois
Copy link
Contributor

CI is failing because of CodeCov upload, will be fixed in another PR

@luciegrau luciegrau merged commit b015259 into develop May 2, 2024
13 of 16 checks passed
@luciegrau luciegrau deleted the backport/budgets_projects_searchable branch May 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants