Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/sms gateway service #519

Merged
merged 6 commits into from
May 16, 2024
Merged

Backport/sms gateway service #519

merged 6 commits into from
May 16, 2024

Conversation

Stef-Rousset
Copy link
Contributor

@Stef-Rousset Stef-Rousset commented Apr 23, 2024 •
edited by moustachu
Loading

🎩 Description

Add sms gateway service

Notion card

Testing

  • Run application with env var
SMS_GATEWAY_USERNAME=<username> \
SMS_GATEWAY_PASSWORD=<pwd> \
SMS_GATEWAY_URL=<url_provider>  \
bundle exec rails s
  • Go to budget 💰
  • Try to vote 📩
  • Enter your phone number ☎️
  • Receive SMS 📱

@Stef-Rousset Stef-Rousset marked this pull request as ready for review April 23, 2024 15:34
@Stef-Rousset Stef-Rousset requested review from a team, BarbaraOliveira13, luciegrau and AyakorK and removed request for a team April 23, 2024 15:34
AyakorK
AyakorK previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@AyakorK AyakorK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Well done !

Quentinchampenois
Quentinchampenois requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your PR !

I just a change request, as explained in the comment below, I want to be able to change the value of config.sms_gateway_service using an environment variable

config/initializers/decidim.rb Outdated Show resolved Hide resolved
Quentinchampenois
Quentinchampenois previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 👍

@Quentinchampenois Quentinchampenois mentioned this pull request Apr 26, 2024
Merged
4 tasks
@Quentinchampenois Quentinchampenois dismissed stale reviews from BarbaraOliveira13 and themself via 3b14588 May 14, 2024 12:42
@luciegrau luciegrau merged commit 12f0d99 into develop May 16, 2024
14 checks passed
@luciegrau luciegrau deleted the backport/sms_gateway_service branch May 16, 2024 13:46
@luciegrau luciegrau mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luciegrau luciegrau luciegrau approved these changes

@Quentinchampenois Quentinchampenois Quentinchampenois left review comments

@AyakorK AyakorK AyakorK left review comments

@BarbaraOliveira13 BarbaraOliveira13 BarbaraOliveira13 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Stef-Rousset @Quentinchampenois @luciegrau @AyakorK @BarbaraOliveira13