Namespaces #17
Merged
Namespaces #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 96.46% 97.71% +1.24%
==========================================
Files 8 10 +2
Lines 453 699 +246
==========================================
+ Hits 437 683 +246
Misses 16 16 ☔ View full report in Codecov by Sentry. |
Member
|
Added a short documentation of the new features. Also added a function that requires no trailing underscores for branches (and mentioned that in the docs). |
8 tasks
Member
|
ToDos:
|
hmgaudecker
approved these changes
Feb 11, 2025
Member
hmgaudecker
left a comment
hmgaudecker
left a comment
There was a problem hiding this comment.
Looks great to me and works very nicely!
I'd say let's merge it and see whether anything comes up over the next couple of months before a GETTSIM release.
Thanks a lot, everyone involved!
Member
|
I am assuming the test errors are a fluke from outdated infrastructure. |
3 tasks
hmgaudecker
added a commit
to ttsim-dev/gettsim
that referenced
this pull request
Feb 15, 2025
This PR adds the namespace infrastructure to GETTSIM. - [x] Write `policy_function` decorator (rename `policy_info` and change behavior so that a `PolicyFunction` instance is returned). ~Apply to all TT functions.~ (that should be part of renamings) - [x] Check that functions in module with same simple_name have the correct start_date, end_date specs (this was removed from the policy_info decorator). - [x] Remove doubled levels in the functions tree automatically (to avoid writing functions in `__init__.py`). - [x] Go over type hints for aggregation functions. - [x] Refactor interface module. - [x] Implement some safety checks - [x] No function should have the same name as a module in the same directory - [x] No trailing underscores in module names (for [DAGS PR](OpenSourceEconomics/dags#17)) --------- Co-authored-by: Marvin Immesberger <[email protected]> Co-authored-by: Tim Mensinger <[email protected]> Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Implement namespaces as described in #14.