Update Goose and disable bundled skills in Agent Mode - #659
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAgent Mode now discovers project skills without built-ins, persists only user-visible timeline content, and propagates session IDs plus configured default timeouts through bounded shell execution. The Goose dependency is pinned to a newer revision. ChangesAgent execution and visibility
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant MCPTool
participant BoundedShell
participant SpawnedShell
MCPTool->>BoundedShell: Pass session ID and shell parameters
BoundedShell->>BoundedShell: Resolve timeout
BoundedShell->>SpawnedShell: Set AGENT_SESSION_ID and execute
SpawnedShell-->>BoundedShell: Return bounded output
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying maple with
|
| Latest commit: |
0dffb6f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34c73ab2.maple-ca8.pages.dev |
| Branch Preview URL: | https://codex-maple-goose-latest-bui.maple-ca8.pages.dev |
Summary
3c1fdd69to current upstreammainatc3111c71(the merge commit for feat(skills): allow disabling built-in skills aaif-goose/goose#10600)with_builtin_skills(false), keeping trusted filesystem/project/plugin skills while excluding Goose-bundled skills such asgoose-doc-guideAGENT_SESSION_IDbehaviorThe pin covers 89 upstream commits. Every commit in the range was reviewed against Maple's directly embedded Goose boundary:
aaif-goose/goose@3c1fdd6...c3111c7
Compatibility details
AGENT_SESSION_IDacross native and Flatpak shell construction and removes stale inherited values when absentreplacecoalescing lossValidation
cargo test --all-targets: 134 passedjust rust-lintpassedgoose-doc-guidewas absentload_skillLoaded skill: maple-goose-builtin-smokeas a completed timeline cardSummary by CodeRabbit
New Features
Bug Fixes