Harden Zapstore zsp install - #626
Conversation
Deploying maple with
|
| Latest commit: |
e92375f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7180b3bb.maple-ca8.pages.dev |
| Branch Preview URL: | https://codex-harden-zapstore-zsp-pi.maple-ca8.pages.dev |
📝 WalkthroughWalkthroughThe Zapstore publishing workflow now pins Go 1.24.11 and validates the zsp v0.4.5 tag, commit, module checksum, and go.mod checksum before installation. Existing APK download and publishing validations remain in place. ChangesZapstore publishing
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/zapstore-publish.yml (1)
81-82: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider
jqinstead of inlinepython3for JSON parsing.
jqis preinstalled onubuntu-latestrunners and is more idiomatic for one-line JSON field extraction in CI shell scripts than shelling out to python3.♻️ Optional refactor using jq
- actual_module_sum="$(python3 -c 'import json, sys; print(json.load(sys.stdin)["Sum"])' <<<"${download_json}")" - actual_gomod_sum="$(python3 -c 'import json, sys; print(json.load(sys.stdin)["GoModSum"])' <<<"${download_json}")" + actual_module_sum="$(jq -r '.Sum' <<<"${download_json}")" + actual_gomod_sum="$(jq -r '.GoModSum' <<<"${download_json}")"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/zapstore-publish.yml around lines 81 - 82, Replace the inline python3 JSON parsing used to assign actual_module_sum and actual_gomod_sum with jq field extraction from download_json. Preserve the existing Sum and GoModSum values and assignment flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/zapstore-publish.yml:
- Around line 81-82: Replace the inline python3 JSON parsing used to assign
actual_module_sum and actual_gomod_sum with jq field extraction from
download_json. Preserve the existing Sum and GoModSum values and assignment
flow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0062b832-93da-4159-b1e3-e41d60efb452
📒 Files selected for processing (1)
.github/workflows/zapstore-publish.yml
Summary
Validation
Note: I could not run go install locally because Go is not installed in this shell.
Summary by CodeRabbit