Move settings to dedicated routes - #611
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (73)
💤 Files with no reviewable changes (14)
✅ Files skipped from review due to trivial changes (9)
🚧 Files skipped from review as they are similar to previous changes (47)
📝 WalkthroughWalkthroughThe PR migrates account, team, billing, API, and history workflows from dialogs into routed settings pages, preserves authenticated home navigation, centralizes internal redirect sanitization, and updates OAuth, payment, deep-link, and route handling. ChangesSettings migration and navigation
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying maple with
|
| Latest commit: |
f3128d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4fdb83e.maple-ca8.pages.dev |
| Branch Preview URL: | https://codex-maple-settings-route-m.maple-ca8.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
Follow-up pushed in
Validation: frontend CI passes with 0 lint errors, TypeScript clean, 14/14 tests, production build green, and |
Contributor
Author
|
Follow-up independent audit completed and pushed in Applied the two validated high-impact fixes plus one tiny responsive consistency improvement:
Revalidation passed: frontend formatting/lint/typecheck, 14 frontend tests, production build, Rust formatting/check, and 9 Rust tests. The focused post-fix re-audits found no new high/critical issues. |
AnthonyRonning
force-pushed
the
codex-maple-settings-route-maple
branch
from
July 11, 2026 06:19
a52d511 to
f3128d2
Compare
Contributor
Author
|
Rebased onto current The Agent Mode core remains byte-identical to Validation passed: Prettier, TypeScript, production build, 65 frontend tests, Rust formatting/check, and all 60 Rust tests. |
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
nix develop .#ci -c ./scripts/ci/frontend.sh(Prettier, ESLint with 0 errors, TypeScript, 14/14 tests)nix develop -c just buildTest note
The local fixture manager provisions Free and Pro users only. Team-plan routes and behavior were source-parity audited because a live Team subscription requires Stripe.
The in-app browser backend was unavailable for the compact-drawer follow-up, so the new animation has build/type/static audit coverage but still needs preview-device visual confirmation.
Summary by CodeRabbit