Refresh Maple pricing page design - #601
Merged
Merged
Conversation
📝 WalkthroughWalkthroughUpdates pricing plan feature icon styling to maple-success/maple-error classes in pricingConfig.tsx, and refactors pricing.tsx's page layout, introducing hero/FAQ/skeleton subcomponents, restyled loading/error states, payment banners, promotion banner, pricing cards, price display, and CTA/bottom controls. ChangesPricing page and config restyle
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying maple with
|
| Latest commit: |
136b293
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://056984ef.maple-ca8.pages.dev |
| Branch Preview URL: | https://codex-maple-pricing-design-m.maple-ca8.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
frontend/src/routes/pricing.tsx (1)
855-859: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueMinor: use
cn()for consistency with other dynamic classNames.This is the only dynamic className built with a template literal instead of
cn(...), which is used elsewhere in this same file for conditional classes (e.g. lines 930-937, 1085-1089).♻️ Optional refactor
- <div - className={`mx-auto grid w-full max-w-7xl grid-cols-1 ${gridColumns} gap-5 px-4 pt-6 sm:px-6 lg:px-8`} - > + <div + className={cn( + "mx-auto grid w-full max-w-7xl grid-cols-1 gap-5 px-4 pt-6 sm:px-6 lg:px-8", + gridColumns + )} + >🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/src/routes/pricing.tsx` around lines 855 - 859, The dynamic className in the pricing route is built with a template literal instead of the shared cn() helper, unlike the other conditional className usages in this file. Update the JSX in the relevant pricing layout block to use cn() for composing the static classes with gridColumns so the pattern stays consistent with the other dynamic className expressions in pricing.tsx.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/routes/pricing.tsx`:
- Around line 726-730: The pricing loading skeleton and the loaded grid switch
to different column counts at different breakpoints, causing a layout shift
between the placeholder and real content. Update the skeleton grid in the
pricing route so its responsive column classes match the same breakpoint logic
used by the loaded plans grid via gridColumns in the pricing page, keeping the
4-column switch aligned at lg instead of md. Verify the responsive classes
around FullPageMain and the pricing plans container use the same behavior for
all viewport sizes.
---
Nitpick comments:
In `@frontend/src/routes/pricing.tsx`:
- Around line 855-859: The dynamic className in the pricing route is built with
a template literal instead of the shared cn() helper, unlike the other
conditional className usages in this file. Update the JSX in the relevant
pricing layout block to use cn() for composing the static classes with
gridColumns so the pattern stays consistent with the other dynamic className
expressions in pricing.tsx.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9b38841a-c170-45e9-89b1-e2cf75b936a9
📒 Files selected for processing (2)
frontend/src/config/pricingConfig.tsxfrontend/src/routes/pricing.tsx
Comment on lines
+726
to
+730
| <FullPageMain className={pricingPageClassName}> | ||
| <PricingReturnButton isLoggedIn={isLoggedIn} onClick={() => navigate({ to: "/" })} /> | ||
| <PricingHero /> | ||
|
|
||
| <div className="pt-8 w-full max-w-7xl mx-auto grid grid-cols-1 md:grid-cols-4 gap-4 md:gap-4 lg:gap-6 px-4 sm:px-6 lg:px-8"> | ||
| <div className="mx-auto grid w-full max-w-7xl grid-cols-1 gap-5 px-4 pt-6 sm:px-6 md:grid-cols-4 lg:px-8"> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Skeleton and real grid switch to 4 columns at different breakpoints.
Loading skeleton uses md:grid-cols-4 (line 730), but the actual pricing grid uses gridColumns from filteredPlans.length === 4 ? "lg:grid-cols-4" : "lg:grid-cols-3" (line 858) — switching at lg, not md. Between 768px and 1024px viewport widths, the skeleton will render 4 columns while the loaded content collapses to 1 column, causing a visible layout shift when data arrives.
🔧 Proposed fix: align skeleton breakpoint with real grid
- <div className="mx-auto grid w-full max-w-7xl grid-cols-1 gap-5 px-4 pt-6 sm:px-6 md:grid-cols-4 lg:px-8">
+ <div className="mx-auto grid w-full max-w-7xl grid-cols-1 gap-5 px-4 pt-6 sm:px-6 lg:grid-cols-4 lg:px-8">Also applies to: 858-858
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/routes/pricing.tsx` around lines 726 - 730, The pricing loading
skeleton and the loaded grid switch to different column counts at different
breakpoints, causing a layout shift between the placeholder and real content.
Update the skeleton grid in the pricing route so its responsive column classes
match the same breakpoint logic used by the loaded plans grid via gridColumns in
the pricing page, keeping the 4-column switch aligned at lg instead of md.
Verify the responsive classes around FullPageMain and the pricing plans
container use the same behavior for all viewport sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Homewhen signed out andChatwhen signed inValidation
http://127.0.0.1:35432/pricingin Chrome using Computer Usenix develop -c bash -c 'cd frontend && bunx prettier --check src/routes/pricing.tsx src/config/pricingConfig.tsx && git diff --check'\n-nix develop -c just lint(passes with 13 existing warnings outside this change)\n-nix develop -c just buildSummary by CodeRabbit
UI Improvements
Bug Fixes