Add FirewalledRule #200
Merged
Add FirewalledRule #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a FirewalledRule which can be extended in order to restrict relaying of meta-transactions to organization workers. The rule that is to be restricted must extend the FirewalledRule and add the modifier `firewalled` to all relevant functions. For testing I created two test contract files. One that uses the modifier, and one that calls the one that uses the modifier. Required in order to simulate rules calling on each other and checking for the relayer. Added a step to manually install npx inside docker until the docker image is fixed. The problem is reported and confirmed at trailofbits/eth-security-toolbox#8 Fixes OpenST#199
|
Crytic fixed the docker image, I should test and remove the extra line before merging! |
|
When they fixed the previously reported bug, it seems they broke something else. I made a new report: trailofbits/eth-security-toolbox#9 Waiting for an update, as this cannot be fixed with a workaround. |
pgev
previously approved these changes
Apr 30, 2019
|
Travis CI cannot cache docker images (https://docs.travis-ci.com/user/caching/#things-not-to-cache):
|
I cannot get the security toolbox to work.
|
@pgev can you please have a look? I removed slither from |
pgev
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a FirewalledRule which can be extended in order to restrict
relaying of meta-transactions to organization workers.
The rule that is to be restricted must extend the FirewalledRule and add
the modifier
firewalledto all relevant functions.For testing I created two test contract files. One that uses the
modifier, and one that calls the one that uses the modifier. Required in
order to simulate rules calling on each other and checking for the
relayer.
Added a step to manually install npx inside docker until the docker
image is fixed. The problem is reported and confirmed at
trailofbits/eth-security-toolbox#8
Fixes #199