Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages are duplicated #707

Closed
jan-cerny opened this issue Mar 14, 2017 · 1 comment
Closed

Error messages are duplicated #707

jan-cerny opened this issue Mar 14, 2017 · 1 comment
Assignees
@jan-cerny
Labels
bug
Milestone
1.2.14

Comments

@jan-cerny
Copy link
Member

Errors that are reported using oscap_seterr are displayed twice.

For example:

$ oscap xccdf eval dsadasd
E: oscap: (oscap_source.c:284:oscap_source_get_xmlDoc()) Unable to open file: 'dsadasd'
OpenSCAP Error: Unable to open file: 'dsadasd' [oscap_source.c:284]

This is probably caused by #630
@jan-cerny jan-cerny added the bug label Mar 14, 2017
@jan-cerny jan-cerny added this to the 1.2.14 milestone Mar 14, 2017
@jan-cerny
Copy link
Member Author

See https://github.com/OpenSCAP/openscap/blob/maint-1.2/src/common/error.c#L57

@jan-cerny jan-cerny self-assigned this Mar 15, 2017
jan-cerny added a commit that referenced this issue Mar 15, 2017
@jan-cerny
Issue #707: Fix duplicated error messages
8585318
jan-cerny added a commit to jan-cerny/openscap that referenced this issue Mar 20, 2017
@jan-cerny
Do not rely on number of lines on stderr
98999c8 
We fixed duplicate error messages (issue OpenSCAP#707). But in this test,
we assumed that there are 6 lines on stderr. Actually two of them
were duplicated. We should not count number of lines on stderr
because we may add a new warning somewhere in our code and it will
break the test again. This commit stops testing stderr line count.
@jan-cerny jan-cerny mentioned this issue Mar 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-cerny jan-cerny

Labels
bug
Projects
None yet
Milestone
1.2.14
Development

No branches or pull requests
1 participant
@jan-cerny