Reduced length of rrc filter. Parameterized some values to make future updates easier #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e updates easier.
Abraxas3d
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced filter length, added comments, and parameterized some values in order to make future changes easier.
I'm confused about the values used in the notebook. We have 10 samples per symbol, but the oversampling factor used was 40. I don't think we multiply by the number of symbols used in the modulation scheme, but if one did that, then we'd get 40 (10*4 = 40, and we see 40 in the 40 * 8 filter length argument).
I set it to 10 * 8 for a filter length of 80. I'd like someone to check this work in case I missed something basic in how rrc filters are calculated using the rrcosfilter function from commpy.
Shortening the filter length should reduce the computational workload? 8 symbol's worth of filter length is a good number. People often use 6.
I don't think this is something that happens automatically in the code. There isn't a connection between this notebook, for example, and a set of taps that could then go into a header file that were generated by something like this notebook. Since we have a Numerology notebook generating the numerology.h file, filter taps could be part of that too.