Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render monorail stations #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JonathanBittner
Copy link
Contributor

fixes #43
looks for station=monorail and/or monorail=yes.

Disables labels for monorail stations in the station labeling layers.
Disable labels for monorail stations in the station labeling layers.
Disable labels for monorail stations in the station labeling layers.
@DerDakon
Copy link
Contributor

DerDakon commented May 8, 2022

I wonder if one can't just tell the database to filter out those stations in the SELECT so the actual rendering code will never see them.

@JonathanBittner
Copy link
Contributor Author

I'll look at that. Stations are interesting since there's a lack of standardization or maybe lack of precision: we show miniature stations sometimes since there's no station=miniature flag.

Copy link
Collaborator

@Nakaner Nakaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from the issue pointed out in my comment.

frankflug-z16

[railway = 'halt'][station != 'funicular'][zoom >= 10],
[railway != 'tram_stop'][station != 'funicular'][zoom >= 11] {
[railway = 'station'][station != 'funicular'][station != 'monorail'][monorail != 'yes'][zoom >= 10],
[railway = 'halt'][station != 'funicular'][station != 'monorail'][zoom >= 10],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally skip `[monorail != 'yes'] here?

@DerDakon DerDakon added the style:infra infrastructure style label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement style:infra infrastructure style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monorails aren't rendered but monorail stations are rendered
3 participants