Add initial support for polish signals #107
Conversation
|
Added support for semaphores and distant signals: Łęgajny station: |
|
Removed a pink outline on some signals. |
|
I removed all the metadata from the SVGs |
| @@ -623,8 +623,12 @@ Format details: | |||
| /* DE distant semaphore signals type Vr which */ | |||
| /* - have no railway:signal:states=* tag */ | |||
| /* - OR have railway:signal:states=* tag that does neither include Vr1 nor Vr2 */ | |||
| /* */ | |||
| /* PL distant semaphore signals type On/Od/Ot */ | |||
There was a problem hiding this comment.
you mention 3 types here, but the lines below add only 2 of them.
signals.mss
Outdated
| ["distant_states"=~"^(.*;)?DE-ESO:vr1(;.*)?$"], | ||
| ["distant_states"=~"^(.*;)?PL-PKP:od2(;.*)?$"], | ||
| ["distant_states"=~"^(.*;)?PL-PKP:ot2(;.*)?$"] { |
There was a problem hiding this comment.
You need to add a ["feature"=… for everything in here now. Before it were only German signals, now you could have mixed tagging. See below for main signals how this is done.
| /*******************************************************/ | ||
| /* PL main, combined and distant light signals */ | ||
| /*******************************************************/ | ||
| ["feature"="PL-PKP:s"] { |
There was a problem hiding this comment.
This is nothing that is up to you, but I wonder if we should factor out the country specific signals to their own files and only #include them here (however that works in CartoCSS). @Nakaner?
|
So, how should I move forward with this? Just move everything into a country specific file? |
The signal images are self-made creations.
Example renderings at Wrocław station and west of it: