Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for request signal on BOStrab:f signals #106

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

besentv
Copy link
Contributor

@besentv besentv commented Oct 28, 2023

The approach is pretty terrible, so I'm open for improvements.

Example rendering in Karlsruhe around Durlacher Tor.

image

Also I'd like to add support for more common combinations, like (pseudo-regex):
F0 [F4]? [F1-3|F5] [A1]? [St9]?

So, most likely these:

  • F0 F4 F1
  • F0 F4 F2
  • F0 F4 F3
  • F0 F4 F5
  • F0 F1 A1
  • F0 F2 A1
  • F0 F3 A1
  • F0 F4 F1 A1
  • F0 F4 F2 A1
  • F0 F4 F3 A1
  • F0 F4 F1 St9
  • F0 F4 F2 St9
  • F0 F4 F3 St9
  • F0 F4 F1 A1 St9
  • F0 F4 F2 A1 St9
  • F0 F4 F3 A1 St9

@besentv
Copy link
Contributor Author

besentv commented Oct 31, 2023

Mhm, I just realized that many cities actually have the A as the very first light, for example:

  • Karlsruhe
  • Mannheim
  • Mainz
  • Kassel
  • Leipzig
    However these have it at the bottom:
  • Nürnberg
  • Erfurt

@besentv
Copy link
Contributor Author

besentv commented Dec 2, 2023

I think i found a better way of implementing this, using layer instances.

@besentv besentv marked this pull request as draft December 2, 2023 16:45
Copy link
Collaborator

@Nakaner Nakaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to ask to start rendering St 9 signals on zoom level 16, not 15 like the F signals. Enlarging the signals by 50% hides more other signals.

Please fix the syntax as well (see inline comment).

Zoom level 15:

kronenplatz-z15

Zoom level 16:

kronenplatz-z16

marker-height: 30;
marker-file: url('symbols/de/bostrab/f3-st9.svg');
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This closing curly brace makes the syntax invalid.

@bjoernma
Copy link
Contributor

bjoernma commented Feb 25, 2024

As I couldnt find St9 in BOStrab (and though it is DE-VBK:st9 in the key definition) it seems that its in most cities more of a railway:signal:main:PT_priority=requested;off in different optical representation. I wouldnt mind if the DE-BSVG version which is basically a single round lamp would be an "A" instead as its the meaning that counts for me. So it would be nice for me (?) to add the PT_priority tag as well.
And I (!) wouldnt mind as well whether its on top or at the bottom, but if its simple done, why not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants