Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F #548: Add method, gateway, dns arguments for nics #555

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

sk4zuzu
Copy link
Collaborator

@sk4zuzu sk4zuzu commented Jun 7, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

VM/Template NIC vectors inherit method, gateway and dns arguments from VNETs and ARs (look here). Those are defnitely useful good-to-have things, we add them to the interface in this PR. 🙂

References

#548

New or Affected Resource(s)

  • opennebula_virtual_machine

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@sk4zuzu sk4zuzu requested review from frousselet and treywelsh and removed request for frousselet and treywelsh June 7, 2024 15:26
@sk4zuzu sk4zuzu marked this pull request as draft June 7, 2024 15:28
@sk4zuzu sk4zuzu marked this pull request as ready for review June 8, 2024 11:28
Copy link

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

@github-actions github-actions bot closed this Jul 17, 2024
@treywelsh treywelsh reopened this Aug 8, 2024
@treywelsh treywelsh requested review from frousselet and removed request for frousselet August 8, 2024 13:15
@frousselet frousselet merged commit caf6777 into master Aug 14, 2024
13 checks passed
@frousselet frousselet deleted the f-548 branch August 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend nic section, add missing arguments like METHOD, GATEWAY or DNS..
3 participants