Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F #547: Add floating_only VR nic IP allocation #549

Merged
merged 1 commit into from
May 22, 2024
Merged

F #547: Add floating_only VR nic IP allocation #549

merged 1 commit into from
May 22, 2024

Conversation

sk4zuzu
Copy link
Collaborator

@sk4zuzu sk4zuzu commented May 20, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Since https://github.com/OpenNebula/one-ee/commit/0a7a03e098d4da6db5f057cec29daf56028b83b6 VR instances support instance deployment without NIC-dedicated IPs if the VIP is defined and is marked floating_only. This PR enables that feature in the Provider.

References

Close #547

New or Affected Resource(s)

  • opennebula_virtual_router_nic

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@sk4zuzu sk4zuzu requested a review from treywelsh May 20, 2024 13:20
@treywelsh treywelsh merged commit 50ab4c3 into master May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opennebula_virtual_router_nic: Add floating_only argument
2 participants