F-498: add support for passwd and random_passwd arguments

[grossibr]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Adds support for passwd and random_passwd arguments for graphics section for VNC so we avoid the following:

│ Error: Unsupported argument
│
│ on ../../_modules/instance/instance.tf line 33, in resource "opennebula_virtual_machine" "instance":
│ 33: passwd = substr(base64encode(random_string.password.result), 0, 8)
│
│ An argument named "passwd" is not expected here.
<!--- Please leave a helpful description of the PR here. --->

References

#498: Add passwd and random_passwd arguments for opennebula_virtual_machine and opennebula_template graphics sections

New or Affected Resource(s)

• opennebula_virtual_machine
• opennebula_template

Checklist

• I have created an issue and I have mentioned it in References
• My code follows the style guidelines of this project (use go fmt)
• My changes generate no new warnings or errors
• I have updated the unit tests and they pass succesfuly - NA
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation (if needed)
• I have updated the changelog file

[grossibr]

@frousselet may I ask you to approve the flows once more?

[frousselet]

Done, @axbgrossi :)

[grossibr]

@frousselet once more if you're available, please

[grossibr]

CI / Test OpenNebula 5.12 error seems unrelated to the changes in this PR, please resume with review

[grossibr]

@treywelsh @frousselet will this be merged by you maintainers when the time comes?

[grossibr]

@frousselet please consider reviewing this PR so we can finally close that issue

[frousselet]

Hello @axbgrossi,

Thanks for your work.

If I understand the documentation, random password should be a boolean (then converted in a 'YES' or a 'NO' string by the provider).
The way you did is a good start but it might be too permissive.

Also, both passwd and random_passwd should conflict with each other.

[grossibr]

@frousselet could you please approve the workflows?

[grossibr]

@frousselet would you be kind to approve the workflows once more?

[frousselet]

Hi @axbgrossi,

Thanks for your work!

There is a SDK native ConflictsWith argument you can use to natively deal with conflicting attributes.

[grossibr]

@frousselet would you please approve the flows once more?

[grossibr]

@frousselet once more please

[treywelsh]

Seems due to the ConflictsWith: their values targets nested Graphics attributes, not attributes at the root of the schema.
So try something "graphics.0.passwd" and "graphics.0.random_passwd". It's ok because Graphics is a typelist with a maximum of 1 element

[grossibr]

Seems due to the ConflictsWith: their values targets nested Graphics attributes, not attributes at the root of the schema. So try something "graphics.0.passwd" and "graphics.0.random_passwd". It's ok because Graphics is a typelist with a maximum of 1 element

done, @treywelsh or @frousselet could you please approve the flows?

[frousselet]

Hello @axbgrossi,

Thanks a lot for your work.
Could you rebase with master and solve merge conflicts please?

Then I will be able to merge and include it in the 1.4.0 release.