Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oneflow should permit to tweak roles at instance #5591

Closed
7 tasks
baby-gnu opened this issue Oct 29, 2021 · 1 comment
Closed
7 tasks

Oneflow should permit to tweak roles at instance #5591

baby-gnu opened this issue Oct 29, 2021 · 1 comment
Assignees
@vickmp
Labels
Category: Orchestration - Flow Community Priority: Low Status: Accepted Type: Feature
Milestone
Release 6.6.1

Comments

@baby-gnu
Copy link
Contributor

Description

When instanciating a OneFlow service, it's not possible to adjust the memory or disk sizes.

Use case

We define a service usable by our users with “normal” personnal capacity.

Sometimes, we may need to deploy a bigger instance of the service.

Interface Changes

During instance of a OneFlow service, we should have the same optional capacity modifications of each roles as when instanciating a VM template.

This will have the advantage of having the modification limiters set in the VM templates

Additional Context

Today, when we define a service, we need to have several service and VM templates:

  • Service foo small
  • Service foo big
  • Service foo huge

Which is limited as we do not provide all the possibility in the range between small and huge.

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@rsmontero rsmontero added this to the Release 6.6.1 milestone Dec 14, 2022
vickmp added a commit to OpenNebula/docs that referenced this issue Jan 27, 2023
@vickmp
F OpenNebula/one#5591: Oneflow custom role attributes doc
e8fc2af
vickmp added a commit to OpenNebula/docs that referenced this issue Jan 27, 2023
@vickmp
F OpenNebula/one#5591: Oneflow custom role attributes doc
02f238e
@vickmp
Copy link
Member

vickmp commented Jan 30, 2023

@tinova PRs to merge:

This functionality also needs to be implemented from the Sunstone side.

rsmontero pushed a commit to OpenNebula/docs that referenced this issue Feb 7, 2023
@vickmp
F OpenNebula/one#5591: Oneflow custom role attributes doc (#2485)
4fc00e4
rsmontero pushed a commit to OpenNebula/docs that referenced this issue Feb 7, 2023
@vickmp @rsmontero
F OpenNebula/one#5591: Oneflow custom role attributes doc (#2485)
6d83c3c 
(cherry picked from commit 4fc00e4)
rsmontero added a commit to OpenNebula/docs that referenced this issue Feb 7, 2023
@rsmontero
F OpenNebula/one#5591: Resolved issues
634c994
rsmontero pushed a commit that referenced this issue Feb 9, 2023
@vickmp @rsmontero
F #5591: Custom role attributes in oneflow added (#2465)
8aae368 
Custom attributes have been added at the role level.
In this way, roles can be individually customized during instantiation.
Added parameters:
- custom_attrs: contains user-defined custom attributes.
- custom_attrs_values: contains the values of the custom_attrs.
  In case of overlapping role and service level attributes, role level attributes will take precedence.

Example:
roles: [
    {
        "name": "role_1",
        ...
        "custom_attrs": {
            "MEMORY": "M|range|memory (mb)|100..500|200",
            "DISK_SIZE": "M|range|disk size (mb)|100..500|250"
        }
    }
]

In order to be used from CLI, the vm_template_contents in the service template must be filled manually.

(cherry picked from commit 90aac4b)
rsmontero added a commit that referenced this issue Feb 9, 2023
@rsmontero
L #5591: Linting (line-length)
88cf47e 
(cherry picked from commit 496ac20)
rsmontero pushed a commit that referenced this issue Feb 9, 2023
@xorel
Revert "F #5591: Custom role attributes in oneflow added (#2465)" (#2491
b82ca03 
)

This reverts commit 8aae368.
rsmontero pushed a commit that referenced this issue Feb 28, 2023
@vickmp @rsmontero
F #5591: Custom role attributes in oneflow added (#2525)
f66ab7a 
(cherry picked from commit d6ec6fa)
rsmontero added a commit that referenced this issue Feb 28, 2023
@rsmontero
Revert "F #5591: Custom role attributes in oneflow added (#2525)"
2ec40c2 
This reverts commit d6ec6fa.

(cherry picked from commit 9bf063b)
rsmontero pushed a commit that referenced this issue Mar 1, 2023
@vickmp
F #5591: Custom role attributes in oneflow added (#2465)
90aac4b 
Custom attributes have been added at the role level.
In this way, roles can be individually customized during instantiation.
Added parameters:
- custom_attrs: contains user-defined custom attributes.
- custom_attrs_values: contains the values of the custom_attrs.
  In case of overlapping role and service level attributes, role level attributes will take precedence.

Example:
roles: [
    {
        "name": "role_1",
        ...
        "custom_attrs": {
            "MEMORY": "M|range|memory (mb)|100..500|200",
            "DISK_SIZE": "M|range|disk size (mb)|100..500|250"
        }
    }
]

In order to be used from CLI, the vm_template_contents in the service template must be filled manually.
rsmontero added a commit that referenced this issue Mar 1, 2023
@rsmontero
L #5591: Linting (line-length)
496ac20
rsmontero pushed a commit that referenced this issue Mar 1, 2023
@xorel @rsmontero
Revert "F #5591: Custom role attributes in oneflow added (#2465)" (#2491
81648c4 
)

This reverts commit 8aae368.

(cherry picked from commit b82ca03)
rsmontero pushed a commit that referenced this issue Mar 1, 2023
@vickmp
F #5591: Custom role attributes in oneflow added (#2525)
d6ec6fa
rsmontero added a commit that referenced this issue Mar 1, 2023
@rsmontero
Revert "F #5591: Custom role attributes in oneflow added (#2525)"
9bf063b 
This reverts commit d6ec6fa.
rsmontero pushed a commit that referenced this issue May 17, 2023
@vickmp @rsmontero
F #5591: Add API support for custom role attrs (#2578)
3342056 
(cherry picked from commit 7a9a6f8)
rsmontero pushed a commit that referenced this issue May 17, 2023
@vickmp @rsmontero
F #5591: Add CLI support for custom role attrs (#2579)
15c4626 
(cherry picked from commit 6b11d98)
sk4zuzu added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Jun 3, 2024
@sk4zuzu
F #553: Scale service roles at cardinality changes
5001d94 
The role scale feature is currently supported in OpenNebula >= 6.8.0,
please refer to OpenNebula/one#5591.
sk4zuzu added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Jun 3, 2024
@sk4zuzu
F #553: Scale service roles at cardinality changes
dbbaa99 
The role scale feature is currently supported in OpenNebula >= 6.8.0,
please refer to OpenNebula/one#5591.
sk4zuzu added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Oct 16, 2024
@sk4zuzu
F #553: Scale service roles at cardinality changes
084898c 
The role scale feature is currently supported in OpenNebula >= 6.8.0,
please refer to OpenNebula/one#5591.
dgarcia18 pushed a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Oct 17, 2024
@sk4zuzu
F #553: Scale service roles at cardinality changes (#554)
5d936fe 
Adds support for OneFlow service scaling at cardinality changes. 

The role scale feature is currently supported in OpenNebula >= 6.8.0,
please refer to OpenNebula/one#5591.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vickmp vickmp

Labels
Category: Orchestration - Flow Community Priority: Low Status: Accepted Type: Feature
Projects
None yet
Milestone
Release 6.6.1
Development

No branches or pull requests
4 participants
@rsmontero @baby-gnu @al3xhh @vickmp