-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMS-17082 : Add Number of Flows per Second (Last 24 Hours) to Usage Stats #7645
Conversation
mwajahatabbasi
commented
Mar 4, 2025
- jira : https://opennms.atlassian.net/browse/NMS-17082
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor changes
.../java/org/opennms/features/datachoices/internal/usagestatistics/UsageStatisticsReporter.java
Outdated
Show resolved
Hide resolved
.../java/org/opennms/features/datachoices/internal/usagestatistics/UsageStatisticsReporter.java
Outdated
Show resolved
Hide resolved
.../java/org/opennms/features/datachoices/internal/usagestatistics/UsageStatisticsReporter.java
Outdated
Show resolved
Hide resolved
.../java/org/opennms/features/datachoices/internal/usagestatistics/UsageStatisticsReporter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few comments.
.../java/org/opennms/features/datachoices/internal/usagestatistics/UsageStatisticsReporter.java
Outdated
Show resolved
Hide resolved
features/datachoices/src/main/resources/OSGI-INF/blueprint/blueprint.xml
Outdated
Show resolved
Hide resolved
.../java/org/opennms/features/datachoices/internal/usagestatistics/UsageStatisticsReporter.java
Outdated
Show resolved
Hide resolved
0a2d957
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!