Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: src/job.js #197

Merged
merged 12 commits into from
Jul 30, 2020
Merged

Documentation: src/job.js #197

merged 12 commits into from
Jul 30, 2020

Conversation

nahuakang
Copy link
Member

@nahuakang nahuakang commented Jul 27, 2020

Description

This PR addresses Issue #125 and makes edits or additions to src/job.js's inline documentation.

Note that the inline documentation will be continuously improved as I progress through the repository :)

Affected Dependencies

N/A

How has this been tested?

N/A

Checklist

@nahuakang nahuakang added the Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase label Jul 27, 2020
@cereallarceny
Copy link
Member

@vvmnnnkv this is up to you to review.

@nahuakang Are you ready to take this out of WIP or do you need more time?

@nahuakang
Copy link
Member Author

@cereallarceny I'll make it ready for review later tonight or tomorrow. Will notify Vova once it's ready!

@nahuakang nahuakang marked this pull request as ready for review July 28, 2020 19:34
src/job.js Outdated Show resolved Hide resolved
src/events.js Outdated Show resolved Hide resolved
@nahuakang nahuakang requested a review from vvmnnnkv July 29, 2020 10:00
@vvmnnnkv vvmnnnkv merged commit 4b266a0 into dev Jul 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the documentation/src-job branch July 30, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants