Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SBGEMM unit test to handle zero elements. #4883

Merged

Conversation

ChipKerchner
Copy link
Contributor

@ChipKerchner ChipKerchner commented Aug 16, 2024

Fix SBGEMM unit test to handle zero elements - since malloc zero bytes fails on some systems.

@ChipKerchner
Copy link
Contributor Author

Fixes malloc(0) failing for AIX.

@martin-frbg
Copy link
Collaborator

Hmm, that's annoying. M,N,K equal 0 might be a valid corner case to test, though not that important.

@martin-frbg martin-frbg added this to the 0.3.29 milestone Aug 16, 2024
@ChipKerchner
Copy link
Contributor Author

ChipKerchner commented Aug 16, 2024

Fixed to handle zero elements.

@ChipKerchner ChipKerchner changed the title Fix SBGEMM unit test to start at 1 instead of 0 Fix SBGEMM unit test to handle zero elements. Aug 16, 2024
@ChipKerchner
Copy link
Contributor Author

ChipKerchner commented Aug 16, 2024

Actually zero length GEMV will not work because of this (and other checks)

if (lda < MAX(1, m))   info = 6;

If it is included, I get this

 ** On entry to SGEMV  parameter number  6 had an illegal value
 ** On entry to SBGEMV  parameter number  6 had an illegal value

@ChipKerchner
Copy link
Contributor Author

ChipKerchner commented Aug 16, 2024

So this PR is ready. Sorry about all the changes.

@martin-frbg
Copy link
Collaborator

Thank you (sorry for causing extra work with what was just a spontaneous thought before going on a long drive)

@martin-frbg martin-frbg merged commit 4850275 into OpenMathLib:develop Aug 17, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants