Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCAL on x86 and RISCV_GENERIC #4817

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Conversation

martin-frbg
Copy link
Collaborator

fixes two oversights from #4807

@mattip
Copy link
Contributor

mattip commented Jul 26, 2024

That was quick, thanks!

@mattip
Copy link
Contributor

mattip commented Jul 26, 2024

Dunno if you want to fix it, there are some errors with Windows_cl starting here

utest\test_gemv.c(22,15): error C2057: expected constant expression

I think that is coming from declarations like this

float A[N * N];
float X[N];
float Y[N];

where N is not a constant expression.

@mattip
Copy link
Contributor

mattip commented Jul 26, 2024

Maybe you could #define N instead

@martin-frbg
Copy link
Collaborator Author

thanks for the pointer - I had seen the failure but did not find the actual error when wading through the Azure log, so was hoping it would be the same C99 thing that broke the manylinux build. indeed these should be defines (but at least that wasn't my fault except for not noticing in review)

@martin-frbg martin-frbg added this to the 0.3.28 milestone Jul 26, 2024
@martin-frbg martin-frbg merged commit 25e148e into OpenMathLib:develop Jul 26, 2024
76 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants