Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore lock in exec_blas_async to prevent race on queue #4112

Closed
wants to merge 1 commit into from
Closed

restore lock in exec_blas_async to prevent race on queue #4112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion driver/others/blas_server_win32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ int blas_server_avail = 0;
/* Local Variables */
static BLASULONG server_lock = 0;

static BLASULONG pool_lock = 0;
static blas_pool_t pool;
static HANDLE blas_threads [MAX_CPU_NUMBER];
static DWORD blas_threads_id[MAX_CPU_NUMBER];
Expand Down Expand Up @@ -420,7 +421,17 @@ int exec_blas_async(BLASLONG pos, blas_queue_t *queue){
pos ++;
}

pool.queue = queue;
LOCK_COMMAND(&pool_lock);

if (pool.queue) {
current = pool.queue;
while (current -> next) current = current -> next;
current -> next = queue;
} else {
pool.queue = queue;
}

UNLOCK_COMMAND(&pool_lock);

// start up worker threads
ReleaseSemaphore(pool.taskSemaphore, pos - 1, NULL);
Expand Down