CI (MSYS2): Configure with -DCMAKE_BUILD_TYPE=Release.
#3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I erroneously assumed that some self-test would trigger the error reported in msys2/MINGW-packages#12857. But that doesn't seem to be the case. Should the reproducer from that downstream report be added to the test suite? |
|
Like suggested by @martin-frbg in #3740, I added a runner with build type |
|
Thank you. (I do not think it is necessary to add the reproducer from the msys issue, and the underlying problem appears to be in the specific compiler version rather than OpenBLAS anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set
CMAKE_BUILD_TYPEtoReleasefor the runners that use MSYS2. IIUC,Nonewas used before because no build type was specified.The self-tests with gcc 12 are likely to fail with this change because of #3740.