Do not require pkg-config to generate the *.pc file#2785
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Aug 19, 2020
Merged
Conversation
Generating the pkg-config file does not actually depend on pkg-config being available.
Neumann-A
approved these changes
Aug 18, 2020
Contributor
There was a problem hiding this comment.
I cannot remember if the prefix variable is defined in openblas.pc or not. If not it would be nice if you could add it to the upstream PR.
BTW: are you back due to lapack-reference being added to vcpkg? Haven't seen you around for a while. Do you have any knowledge of the progress of the flang driver on windows? I would like to test the lapack-reference with a fortran compiler outside of vcpkg.
Wrong github repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating the pkg-config file does not actually depend on pkg-config being available, so we can always just generate it.
This has the benefit to make the output of the build process more consistent. The pkg-config files will always be generated, no matter whether I install pkg-config before building OpenBLAS or afterwards.
Additionally it is more consistent with the *.pc files that are generated by LAPACK if it is enabled: Those files are being generated unconditionally.