Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft Windows 10 UWP build support #1212

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

neilsh-msft
Copy link
Contributor

@neilsh-msft neilsh-msft commented Jun 23, 2017

This change adds support for building Windows UWP compatible binaries.

  • Removed gen_config_h, getarch and getarch_2nd from CMake generation when building for UWP. When built as UWP applications, these require running in an appcontainer and cannot be invoked during build time. In order to build OpenBLAS for UWP, first run CMake as regular win32/64 configuration to generate executables. Then remove CMakeCache.txt and CMakeFiles directory and re-run CMake for UWP configuration and build resulting OpenBLAS.sln.
  • UWP doesn't support environment variables. Changed environment variable functions to no-ops.
  • UWP doesn't support TerminateThread(). #ifdef'ed out for UWP compilation.
  • config.h still requires #define OS_WINNT 1 to build UWP library. Explicitly add during CMake phase.
  • Update CMakeLists.txt to still build gencblas, genconfig, and genf77blas for ALL_BUILD target.

@brada4
Copy link
Contributor

brada4 commented Jun 29, 2017

It looks good. It could be perfectioned with lots of typing to distinguish 2 build steps involved, but your description could land in FAQ instead as well.

@xianyi xianyi merged commit c66b842 into OpenMathLib:develop Jul 3, 2017
@xianyi
Copy link
Collaborator

xianyi commented Jul 3, 2017

@neilsh-msft
Copy link
Contributor Author

@brada4
Copy link
Contributor

brada4 commented Jul 11, 2017

I have added explanatory 3rd party source to avoid misunderstandings. Feel free to fix me with permalink.

@neilsh-msft
Copy link
Contributor Author

Link to Wikipedia article on UWP looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants