Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onyx group vars #50

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fix onyx group vars #50

merged 2 commits into from
Aug 3, 2023

Conversation

velomatt
Copy link
Contributor

@velomatt velomatt commented Aug 3, 2023

  • gather_facts cannot be defined in group_vars
  • become and become_method cannot be defined in group_vars, but ansible_become and ansible_become_method can
  • since these are now defined in group_vars we can remove the overrides from the onyx playbooks
  • This fixes a regression where some onyx commands fail, for example any command using | json-print

Confirmed above changes resolve regression.

@velomatt velomatt requested a review from a team as a code owner August 3, 2023 22:21
snubatreus
snubatreus approved these changes Aug 3, 2023
View reviewed changes
Copy link

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@velomatt velomatt merged commit 7557482 into master Aug 3, 2023
1 check passed
@velomatt velomatt deleted the fix-onyx-group_vars branch August 3, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snubatreus snubatreus snubatreus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@velomatt @snubatreus