Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor minio cleanup on format plays #37

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Refactor minio cleanup on format plays #37

merged 3 commits into from
Jun 21, 2023

Conversation

velomatt
Copy link
Contributor

This fixes a logic issue when running one of the format plays.

Prior to this fix, the format workflow would:

  1. stop DSS software
  2. put disks into spdk
  3. mkfs_blobfs
  4. start target
  5. mount subsystems w/ driver
  6. start MinIO
  7. stop MinIO
  8. run MinIO cleanup script
  9. start MinIO

With this change, there is no longer a needless start / stop MinIO. The MinIO cleanup script will run prior to starting MinIO the first time.

@velomatt
refactor minio cleanup
c1073da 
- don't start minio prior to running cleanup
- run minio cleanup prior to initial minio startup depending on var
@velomatt
Add missing cleanup var
56a97d4
@velomatt
fix var name
bbb8b28
@velomatt velomatt requested a review from a team as a code owner June 21, 2023 21:30
@velomatt
Copy link
Contributor Author

Have tested with these changes:

  • playbooks/cleanup_dss_minio.yml
  • playbooks/format_restart_dss_software.yml
  • playbooks/format_redeploy_dss_software.yml

All now succeed without having to start/stop MinIO a second time

nsarras
nsarras approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@nsarras nsarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@velomatt velomatt merged commit f7375e5 into master Jun 21, 2023
@velomatt velomatt deleted the refactor-minio-cleanup-on-format-plays branch June 21, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarras nsarras nsarras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@velomatt @nsarras