Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add download_artifacts playbook and role #30

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Add download_artifacts playbook and role #30

merged 2 commits into from
Jun 1, 2023

Conversation

velomatt
Copy link
Contributor

  • Allows automatic download of latest artifacts from public s3
  • by default master branch artifacts are downloaded
  • s3 url can be overridden
  • branch name can be overridden

@velomatt
Add download_artifacts playbook and role
8195976 
- Allows automatic download of latest artifacts from public s3
- by default master branch artifacts are downloaded
- s3 url can be overridden
- branch name can be overridden
@velomatt velomatt requested a review from a team as a code owner May 31, 2023 22:51
@velomatt
Copy link
Contributor Author

  • Tested on intranet from public AWS S3 URL, master branch (default)
  • Tested on intranet from public AWS S3 URL, stable/v1.0 branch (override)
  • Tested in lab network from local MinIO S3 URL, master branch (override)
  • Tested in lab network from local MinIO S3 URL, feature/value-add branch (override)
  • Tested idempotency (eg - downloads artifact only if not already present in artifacts directory)

snubatreus
snubatreus previously approved these changes May 31, 2023
View reviewed changes
Copy link

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

nsarras
nsarras previously approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@nsarras nsarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Do we want to also add the role into the deployment playbook?

@velomatt
Copy link
Contributor Author

velomatt commented Jun 1, 2023

I think this is a good idea. But if I do that, I think it would make sense to be able to optionally not download (eg - if I want to deploy custom artifacts I already have in my artifacts directory). I will check in those changes shortly for your review.

@velomatt
Download artifacts by default
ceceffc 
- during `deploy` plays, we will attempt to download artifacts
- this can be overridden by passing var `download_artifacts=false`
@velomatt velomatt dismissed stale reviews from nsarras and snubatreus via ceceffc June 1, 2023 18:25
@velomatt
Copy link
Contributor Author

velomatt commented Jun 1, 2023

Demonstration of download_artifacts override behavior:

image

@nsarras
Copy link
Contributor

nsarras commented Jun 1, 2023

yes that works! great option to have

Demonstration of download_artifacts override behavior:

image

@velomatt velomatt merged commit 5b9377f into master Jun 1, 2023
@velomatt velomatt deleted the Add-download-artifacts-role-and-playbok branch June 1, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarras nsarras nsarras approved these changes

@snubatreus snubatreus snubatreus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@velomatt @nsarras @snubatreus