Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for Gen2 DSS deployment automation #28

Merged
merged 9 commits into from
Jun 8, 2023
Merged

Adding support for Gen2 DSS deployment automation #28

merged 9 commits into from
Jun 8, 2023

Conversation

nsarras
Copy link
Contributor

@nsarras nsarras commented May 27, 2023

No description provided.

@nsarras nsarras requested a review from a team as a code owner May 27, 2023 00:53
@nsarras nsarras linked an issue May 27, 2023 that may be closed by this pull request
Gen2 Automation #21
Closed
@velomatt velomatt marked this pull request as draft May 27, 2023 00:56
@nsarras nsarras marked this pull request as ready for review June 1, 2023 23:05
velomatt
velomatt requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments in-line

roles/create_client_library_conf/templates/conf.json.j2 Outdated Show resolved Hide resolved
roles/get_combined_vlan_ip_map/tasks/main.yml Outdated Show resolved Hide resolved
roles/start_dss_host/tasks/setup_host_clusters.yml Outdated Show resolved Hide resolved
velomatt
velomatt reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting suggesting for j2

roles/create_client_library_conf/templates/conf.json.j2 Show resolved Hide resolved
velomatt
velomatt approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested against VM cluster. Deployed successfully w/ gen2=true flag, and test_s3_benchmark also succeeds. Resolved all conversation👍

@nsarras nsarras merged commit d54ae7d into master Jun 8, 2023
@nsarras nsarras deleted the 21-gen2-automation branch June 8, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velomatt velomatt velomatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gen2 Automation
2 participants
@nsarras @velomatt