GitHub Actions Lint: spellintian, codespell #1818
Conversation
|
@peternewman spellintian complains of a lot of speeling errors. Have these always been present but the CI has just been ignored, or are these appearing for the first time? I am able them reproduce it locally. |
👍 but doing it in another PR probably makes sense so this one doesn't get stuck! |
Yeah the spelllintian stuff has been allowed failures historically: Unfortunately Travis seems to have cycled the old logs now... As there was no easy way to ignore stuff I just used to manually check them occasionally. |
OK, I will make spellintian generate warnings instead of errors then and will make it always pass (unless the linter fails to run of course). |
…nings, separate spelling tasks
DaAwesomeP
changed the title
|
OK, I made spellintian always pass for now and it generates warning annotations instead of errors. Unfortunately GitHub Actions has a continue-on-failure option for specific steps, but it will still mark the workflow as failed.
|
|
Can you resync please @DaAwesomeP to reduce the diff here. I can hit the button but I figured it you might find it easier if you do it directly your end. |
|
@peternewman Try reloading? I see only 3 files changed. |
|
Doh, of course it's just done it! |
Co-authored-by: Peter Newman <[email protected]>
…/ola into DaAwesomeP-GitHubActionsLint2
Co-authored-by: Peter Newman <[email protected]>
|
@peternewman OK, I think this one is good to go! |
| @@ -0,0 +1,99 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
As sort of mentioned before, I'm beginning to wonder more if this should all become ci.sh or part of the Makefile or something, I'm not really sure. Probably makes sense to leave it until everything is migrated so we can easily re-assess what it all looks like compared to .travis-ci.sh .
There was a problem hiding this comment.
Yeah, I have some ideas for wrapping things but I just want to get everything working initially first. I'm significantly changing things such that I would write a new ci.sh from scratch probably. The current one is very Travis-centric.
There was a problem hiding this comment.
Yeah that's cool, lets leave this for the future then.
2 participants
Working toward #1815. This is still a draft. This pull is a WIP. It should not be merged until after #1817 is merged.
I have so far put both spelling tasks in one script, as they both require the same dynamically generated file list.
I will probably try Doxygen next.