NEWS updates #1816
Merged
NEWS updates #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripton
approved these changes
Feb 15, 2023
| RDM Tests: | ||
| * | ||
| * Python 3 compatibility of the RDM Tests #1599 | ||
| * Fix a longstanding bug in the GetMaxPacketSize RDM test around timeouts |
There was a problem hiding this comment.
It was #1736 but looking at NEWS we've historically not bothered putting PR numbers in, just issue numbers when people reported it. I think I probably just caught this by inspection or when doing something else.
There was a problem hiding this comment.
I've taken them out for now and I'll put them in the other PR so they just appear at the correct time...
Sorry commented on the wrong comment
|
Merging as I've addressed the majority of @kripton 's comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.