[0.10] Java: "mvn test" fails due too old Java requirements

[kripton]

Starting to work on https://github.com/OpenLightingProject/ola/security/dependabot/1, I tried running the tests locally. However, Maven refuses to run them since the Java requirements are too old:

kripton@momo ~/git/ola/java $ mvn test
[...]
[INFO] Compiling 3 source files to /home/kripton/git/ola/java/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] error: Source option 5 is no longer supported. Use 6 or later.
[ERROR] error: Target option 1.5 is no longer supported. Use 1.6 or later.
[INFO] 2 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.814 s
[INFO] Finished at: 2023-03-05T20:42:02+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project ola-java-client: Compilation failure: Compilation failure: 
[ERROR] error: Source option 5 is no longer supported. Use 6 or later.
[ERROR] error: Target option 1.5 is no longer supported. Use 1.6 or later.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

I'm no Java expert, I don't really know if we ship the Java API in our Debian package or for any other distro but with Java 8 basically being obsolete (I'm usually on Java 11 or Java 17), I'd say an update might be advisable ;)

[kripton]

Oh, okay I can see that this has been fixed in master but not in 0.10:
391c480

[peternewman]

I'm no Java expert, I don't really know if we ship the Java API in our Debian package or for any other distro but with Java 8 basically being obsolete (I'm usually on Java 11 or Java 17), I'd say an update might be advisable ;)

I don't think Debian has it currently (unless @yoe wants to correct me). I think it might be an option with things like Homebrew, but I don't think it's installed by default there.

Oh, okay I can see that this has been fixed in master but not in 0.10: 391c480

Since I'm able to build & test in master branch (in contrast to 0.10, see #1829), I did the bump here. Should probably be back-ported to 0.10 as well but without the changes done in master to the Java build system, I cannot test.

If we backport, we should also backport this commit too (for the same reason as it was made originally):
a6df5c4

[DaAwesomeP]

It's not in the Debian package IIRC (or at least the version in this repo--I'm unsure about what's on Debian Salsa), but I did run into it in #1836. The CI build is cancelling itself, but it builds fine locally on a Debian 11 VM. I'm simply installing packages default-jdk-headless and maven. I am not sure if I tried the tests but I can try them soon.