Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eighth batch of jakarta data messages #29696

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Sep 20, 2024

Translatable messages for Jakarta Data for:
createResource failure
DDL generation errors
Entity name collisions
Various issues with record entities

@njr-11
Copy link
Contributor Author

njr-11 commented Sep 20, 2024

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_K5boMHeUEe-ZBdXWdK7Miw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=6ee34cff-ffb7-43fb-8760-11b086db3161

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build njr-11-29696-20240920-2212
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_K5boMHeUEe-ZBdXWdK7Miw
completed successfully!

Copy link

@helyarp helyarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID review partially completed (to CWWKD1069). I'll finish reviewing later.

within {2} seconds for the following entities: {3}.
CWWKD1065.ddlgen.timeout.explanation=The DDL generation attempt timed out \
and did not complete.
CWWKD1065.ddlgen.timeout.useraction=Reattempt DDL generation at a later time \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "at a later time"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating as suggested

to make the following entities available within {2} seconds: {3}.
CWWKD1067.ddlgen.emf.timeout.explanation=Acquisition of the resources needed \
for DDL generation timed out and did not complete.
CWWKD1067.ddlgen.emf.timeout.useraction=Reattempt DDL generation at a later time \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "at a later time"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating as suggested

Jakarta Persistence annotations to explicitly resolve the name conflict.

CWWKD1069.record.entity.name.conflict=CWWKD1069E: The {0} repository interface \
has multiple entities named {1} which are provided by different classes: {2}. \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "which" with "that" or put a comma before "which"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to use "that". Thanks for spotting this.

Copy link
Contributor Author

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID review partially completed (to CWWKD1069). I'll finish reviewing later.

Thanks! Fixes from this first part of the review are in d2002b7
This includes all of the changes you asked for except for the one about explaining the error, which I cannot due because we don't know what the error is. It is a case where we received the error from elsewhere, not one where we have detected an error condition ourselves.

within {2} seconds for the following entities: {3}.
CWWKD1065.ddlgen.timeout.explanation=The DDL generation attempt timed out \
and did not complete.
CWWKD1065.ddlgen.timeout.useraction=Reattempt DDL generation at a later time \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating as suggested

to make the following entities available within {2} seconds: {3}.
CWWKD1067.ddlgen.emf.timeout.explanation=Acquisition of the resources needed \
for DDL generation timed out and did not complete.
CWWKD1067.ddlgen.emf.timeout.useraction=Reattempt DDL generation at a later time \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating as suggested

Jakarta Persistence annotations to explicitly resolve the name conflict.

CWWKD1069.record.entity.name.conflict=CWWKD1069E: The {0} repository interface \
has multiple entities named {1} which are provided by different classes: {2}. \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to use "that". Thanks for spotting this.

Copy link

@helyarp helyarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed ID review

when the system and database are not under load.

CWWKD1068.entity.name.conflict=CWWKD1068E: The {0} repository interface has \
multiple entities named {1} which are provided by different classes: {2}. \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "which" with "that" or add a comma before "which"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed to use "that" in b6267bd

@njr-11
Copy link
Contributor Author

njr-11 commented Sep 23, 2024

#build
#libby

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=b67e7222-b587-4564-8d3c-3ddb9aa2a039

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_SSikwHn6Ee-PXJdaQbhamQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 6 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops

  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops

@LibbyBot
Copy link

@njr-11
Copy link
Contributor Author

njr-11 commented Sep 24, 2024

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=b67e7222-b587-4564-8d3c-3ddb9aa2a039 has errors/failures.

Build has 1 intermittent test failure, which is a preexisting issue in an unrelated test bucket.

@njr-11 njr-11 merged commit 7abfb88 into OpenLiberty:integration Sep 24, 2024
2 checks passed
@LibbyBot
Copy link

The build njr-11-29696-20240923-1630
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_SSikwHn6Ee-PXJdaQbhamQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_SSikwHn6Ee-PXJdaQbhamQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants