Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gvt failure in some locales by overriding to utf8 #29667

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

nijoj
Copy link
Contributor

@nijoj nijoj commented Sep 17, 2024

Fixes #29665

@nijoj
Copy link
Contributor Author

nijoj commented Sep 17, 2024

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=07ad06c4-5d05-4354-9573-ee8a9a28054a

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_pQxRUHTnEe-ZBdXWdK7Miw

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build nijoj-29667-20240917-0535
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_pQxRUHTnEe-ZBdXWdK7Miw
completed successfully!

@nijoj
Copy link
Contributor Author

nijoj commented Sep 18, 2024

!GVT
artifact_execution_id=_vKvx4XTmEe-ZBdXWdK7Miw
bucket_image_artifact_execution_id=_vFVGYHTmEe-ZBdXWdK7Miw

@nijoj
Copy link
Contributor Author

nijoj commented Sep 18, 2024

!GVT
artifact_execution_id=_vKvx4XTmEe-ZBdXWdK7Miw

@seethalm
Copy link
Contributor

seethalm commented Sep 18, 2024

!GVT
artifact_execution_id=_pQxRUHTnEe-ZBdXWdK7Miw
bucket_image_artifact_execution_id=_vFVGYHTmEe-ZBdXWdK7Miw

@nijoj
Copy link
Contributor Author

nijoj commented Sep 25, 2024

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1cd3a15e-3d5c-44c9-b99a-db2fe7400f01

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LoB_oHsuEe-PXJdaQbhamQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build nijoj-29667-20240925-1221
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LoB_oHsuEe-PXJdaQbhamQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_LoB_oHsuEe-PXJdaQbhamQ

@nijoj
Copy link
Contributor Author

nijoj commented Sep 30, 2024

!build
git.clone.repository.username=nijo
git.clone.repository.branch=32727-fixGvtUiTest
fat.buckets.to.run=all

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=57799824-ee8c-4ede-ae3f-40db06bd6bb0

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=53919524-e974-46ae-a7c9-b368f7344492

Target locations of links might be accessible only to IBM employees.

@nijoj
Copy link
Contributor Author

nijoj commented Oct 1, 2024

!build
git.clone.repository.username=nijo
git.clone.checkout.branch=32727-fixGvtUiTest
fat.buckets.to.run=all

@LibbyBot
Copy link

LibbyBot commented Oct 1, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=13f06a4d-9887-4664-8b7f-b42619066afc

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 1, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=6534e83b-cb4c-4ad9-b651-a2b669a82785

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 1, 2024

@LibbyBot
Copy link

LibbyBot commented Oct 1, 2024

Copy link
Member

@websterc87 websterc87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Passing in GVT and PB.
This should work across the board but Iseries and ZOS failures are worth looking out for.

@seethalm
Copy link
Contributor

seethalm commented Oct 1, 2024

#run-libby-bot

@LibbyBot
Copy link

LibbyBot commented Oct 1, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • Please describe in a separate comment how you tested your changes.

  • 1 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

@nijoj nijoj merged commit faa80ee into OpenLiberty:integration Oct 2, 2024
2 of 3 checks passed
@wraschke
Copy link
Member

wraschke commented Oct 3, 2024

@nijoj this is causing hard break 302151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix GVT failure for non-English locales
5 participants