Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port MYFACES-4679 to 2.2 #29647

Draft
wants to merge 4 commits into
base: integration
Choose a base branch
from

Conversation

volosied
Copy link
Member

@volosied volosied commented Sep 13, 2024

For #29648

ID Review is NOT needed as I'm only removing copyrights from the messages files (to match upstream since really shouldn't be licensed under EPL 2.0)

@volosied volosied added regression This bug is for something that worked in a past release, but no longer does release bug This bug is present in a released version of Open Liberty labels Sep 13, 2024
@volosied volosied self-assigned this Sep 13, 2024
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 94 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 7 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 20 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_fr.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_HK.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_nl.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_it.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_CN.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_TW.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_de.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_CN.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_fr.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_de.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_TW.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_nl.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_it.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_es.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_ru.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_es.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_HK.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_ru.js

@volosied
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=ec2d6996-474c-4c57-bfbe-df7caa8a8235

Target locations of links might be accessible only to IBM employees.

@volosied volosied marked this pull request as draft September 13, 2024 18:12
@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_-l3EMnH1Ee-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build volosied-29647-20240913-1837
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_-l3EMnH1Ee-0ZL4JeBVc2g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_-l3EMnH1Ee-0ZL4JeBVc2g

@dmuelle
Copy link
Member

dmuelle commented Sep 17, 2024

Hi @volosied - are there new messages here that need ID review? If not you can add the ID review not needed label to bypass review. I do notice though that Messages.js looks odd, the metadata us being deleted and all the message file content appears to be on a single line

@dmuelle
Copy link
Member

dmuelle commented Sep 17, 2024

sorry, just noticed this is still in draft, feel free to disregard my comment if not ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed ID review not needed regression This bug is for something that worked in a past release, but no longer does release bug This bug is present in a released version of Open Liberty
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants