Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install errors and messages #29060

Merged
merged 13 commits into from
Jul 18, 2024
Merged

Install errors and messages #29060

merged 13 commits into from
Jul 18, 2024

Conversation

cbridgha
Copy link
Member

@cbridgha cbridgha commented Jul 13, 2024 •
edited
Loading

This PR has changes reacting to results coming from the installServer Action possibly including versionless / platforms in the server.xml.

2 new Messages have been added explaining issues with bad platform names and the possibility no platform could be determined with the collection of passed features.

The existing messages in place take care of other scenarios like feature not found, resoltion problems etc... so no change there.

2 new tests were also added that look for the new messages, The fat tests in general were restructured to use one of two repo's, the later is a new copy containing versionless features - Versionless tests are using the new local repo.

@cbridgha
Copy link
Member Author

#build

@cbridgha cbridgha self-assigned this Jul 13, 2024
@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CIqFEEDsEe-Hn95lLM_tGQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=c15f07d7-fe13-49c9-9485-ef89563aaa19

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=c15f07d7-fe13-49c9-9485-ef89563aaa19 has errors/failures.

@cbridgha
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_mAz-QEFnEe-F88sHKWQ5jw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=85f07ce9-a522-4ace-9000-4f1148a13303

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build cbridgha-29060-20240713-0852
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CIqFEEDsEe-Hn95lLM_tGQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_CIqFEEDsEe-Hn95lLM_tGQ

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=85f07ce9-a522-4ace-9000-4f1148a13303 has errors/failures.

@cbridgha
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=15105186-c6e5-480c-9ab5-cedb90419365

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LBsF8EHWEe-F88sHKWQ5jw

Target locations of links might be accessible only to IBM employees.

@cbridgha cbridgha mentioned this pull request Jul 14, 2024
Merged
@LibbyBot
Copy link

The build cbridgha-29060-20240713-1638
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_mAz-QEFnEe-F88sHKWQ5jw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_mAz-QEFnEe-F88sHKWQ5jw

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=15105186-c6e5-480c-9ab5-cedb90419365 completed.

@LibbyBot
Copy link

The build cbridgha-29060-20240714-0550
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LBsF8EHWEe-F88sHKWQ5jw
completed successfully!

dmuelle
dmuelle requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID review

dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/resources/InstallKernel.nlsprops Outdated Show resolved Hide resolved
dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/resources/InstallKernel.nlsprops Outdated Show resolved Hide resolved
dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/resources/InstallKernel.nlsprops Outdated Show resolved Hide resolved
dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/resources/InstallKernel.nlsprops Outdated Show resolved Hide resolved
dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/resources/InstallKernel.nlsprops Outdated Show resolved Hide resolved
dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/resources/InstallKernel.nlsprops Outdated Show resolved Hide resolved
@cbridgha
Copy link
Member Author

#build

dmuelle
dmuelle previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d906348d-8f3a-4504-9fb1-c08664342435

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_BfsOgEOHEe-F88sHKWQ5jw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d906348d-8f3a-4504-9fb1-c08664342435 completed.

cbridgha and others added 10 commits July 17, 2024 10:45
@cbridgha
New install messages for versionless and platforms
0aead11
@cbridgha
Add versionless tests covering new errors
2057374
@cbridgha @dmuelle
Update dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/r…
8b558dd 
…esources/InstallKernel.nlsprops


Updating ERROR_MISSING_PLATFORM_NAME=CWWKF1515E for doc review

Co-authored-by: David Mueller <[email protected]>
@cbridgha @dmuelle
Update dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/r…
ec44109 
…esources/InstallKernel.nlsprops


Doc review for ERROR_MISSING_PLATFORM_NAME.explanation

Co-authored-by: David Mueller <[email protected]>
@cbridgha @dmuelle
Update dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/r…
24cf1b0 
…esources/InstallKernel.nlsprops


Doc review for ERROR_MISSING_PLATFORM_NAME.useraction

Co-authored-by: David Mueller <[email protected]>
@cbridgha @dmuelle
Update dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/r…
8cf8d93 
…esources/InstallKernel.nlsprops


Doc review for ERROR_NO_DERIVED_PLATFORM=CWWKF1516E

Co-authored-by: David Mueller <[email protected]>
@cbridgha @dmuelle
Update dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/r…
4b362f8 
…esources/InstallKernel.nlsprops


Doc review for ERROR_NO_DERIVED_PLATFORM.explanation

Co-authored-by: David Mueller <[email protected]>
@cbridgha @dmuelle
Update dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/r…
67fcf9f 
…esources/InstallKernel.nlsprops


Doc review for ERROR_NO_DERIVED_PLATFORM.useraction

Co-authored-by: David Mueller <[email protected]>
@cbridgha
Add new repo, and enabling versionless tests
67a010b
@cbridgha
Remove versionless causes in Exception message
4eb0c5d
@cbridgha
Copy link
Member Author

Latest build with all changes: https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_7eea0ES2Ee-ngPvsOTExmw

@jjiwooLim jjiwooLim self-requested a review July 18, 2024 20:23
jjiwooLim
jjiwooLim approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@jjiwooLim jjiwooLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cbridgha
Copy link
Member Author

#libby

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 5 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 9 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/resources/InstallKernel.nlsprops

  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.install/resources/com/ibm/ws/install/internal/resources/InstallKernel.nlsprops

@cbridgha cbridgha merged commit 28e1da3 into OpenLiberty:integration Jul 18, 2024
2 checks passed
@LibbyBot
Copy link

The build cbridgha-29060-20240717-2144
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_7eea0ES2Ee-ngPvsOTExmw
completed successfully!

@cbridgha cbridgha mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjiwooLim jjiwooLim jjiwooLim approved these changes

@dmuelle dmuelle dmuelle left review comments

Assignees

@cbridgha cbridgha

Labels
CLA Signed ID reviewed in:Kernel/Bootstrap L2 Reviewed Versionless
Projects
Versionless Features Development
Status: Completed Versionless Tasks
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cbridgha @LibbyBot @jjiwooLim @dmuelle @posmith