Versionless prep for install #28981
Versionless prep for install #28981
Conversation
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
cbridgha
force-pushed
the
InstallVersionless
branch
3 times, most recently
from
4a1bdc2
to
e942d38
Compare
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_b9UW4DzDEe-Hn95lLM_tGQ Target locations of links might be accessible only to IBM employees. |
|
We could not perform your request. We allow builds for authorized users and trusted code only. |
1 similar comment
|
We could not perform your request. We allow builds for authorized users and trusted code only. |
|
#build |
|
We could not perform your request. We allow builds for authorized users and trusted code only. |
|
#build |
|
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8ced16a8-07e0-43a3-b4ae-ce3171e02a88 Target locations of links might be accessible only to IBM employees. |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ZFZKcD1mEe-Hn95lLM_tGQ Target locations of links might be accessible only to IBM employees. |
| * Test the install of versionless servlet from maven central. Multi-version is not | ||
| * supported with installServerFeature as it cannot be installed to same | ||
| * resource. |
There was a problem hiding this comment.
| * Test the install of versionless servlet from maven central. Multi-version is not | |
| * supported with installServerFeature as it cannot be installed to same | |
| * resource. | |
| * Test the install of versionless servlet from maven central. "jakartaee-10.0" and "servlet" configuration should install servlet-6.0. |
There was a problem hiding this comment.
We'll need to time any special tetss that actually go out to Maven Central - because these haven't been published yet
| String[] param1s = { "installServerFeatures", "serverX", "--verbose" }; | ||
| ProgramOutput po = runFeatureUtility(METHOD_NAME, param1s); | ||
|
|
||
| checkCommandOutput(po, 21, "CWWKF1405E", null); |
There was a problem hiding this comment.
| checkCommandOutput(po, 21, "CWWKF1405E", null); | |
| String[] filesList = { "/lib/features/com.ibm.websphere.appserver.servlet-6.0.mf" }; | |
| checkCommandOutput(po, 0, null, filesList); |
There was a problem hiding this comment.
Thanks - these tests will be enabled and fixed after the repo PR is finished... probably a few days from now...
| File serverXmlFile = sa.getServerXmlFile(); | ||
| FeaturesPlatforms fp = InstallUtils.getFeatures(serverXmlFile.getAbsolutePath(), serverXmlFile.getName(), new HashSet<String>()); | ||
| assertTrue(fp.getFeatures().containsAll(Arrays.asList("genericCoreFeature", "featureA-1.0", "featureB-1.0", "featureC-1.0"))); | ||
| assertTrue(fp.getPlatforms().containsAll(Arrays.asList("jakartaee-10.0"))); |
There was a problem hiding this comment.
publish/servers/serverA/server.xml should include
<platform>jakartaee-10.0</platfrom>
There was a problem hiding this comment.
There was a problem hiding this comment.
and this test does run in the build so we'll know soon if it passes. :)
There was a problem hiding this comment.
sorry missed that earlier
cbridgha
force-pushed
the
InstallVersionless
branch
from
e942d38
to
1b4e86b
Compare
|
#build |
|
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4945f4ad-3fde-456c-a2fe-cc731c7851a7 Target locations of links might be accessible only to IBM employees. |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_kfPv0D4wEe-Hn95lLM_tGQ Target locations of links might be accessible only to IBM employees. |
|
The build cbridgha-28981-20240709-0834 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_Qq-KUD3_Ee-Hn95lLM_tGQ |
|
The build cbridgha-28981-20240709-1427 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_kfPv0D4wEe-Hn95lLM_tGQ |
Initial code changes preparing for passing "platforms" from server.xml in install scenarios
Changes to InstallUtils that reads the server.xml for a list of features, now returns both features and platforms lists
FeatureUtility propagates these values for the "InstallServerAction"
Added tests for passing platforms and versionless features (Although disabled until all code is in place)
Added unit test for Server Asses reading features and platforms
Previous question around also passing EnvVar values... this is not needed, as the Kernel resolver does all of this work, and only needs the new "platforms" list to help determine what feature set to install.
Repository changes are also coming, and we'll need to change the TODO in the InstalMap class to also pass platform list.
For now this will put the parsing, and tests in place...