Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip Liberty Config LS jar version when copying over into build/server directory #173

Closed
kathrynkodama opened this issue Nov 25, 2022 · 0 comments · Fixed by #486
Closed
Assignees
Labels
1 Estimated story points enhancement New feature or request language client language server integration low priority
Milestone

Comments

@kathrynkodama
Copy link
Contributor

In the build.gradle, we strip the versions of the LS jars so that we don't have to update the launcher code for new versions.

rename '^(.*)(-[0-9]+.[0-9]+.[0-9]+(-SNAPSHOT)?)(.*)$', '$1$4'

The version is still present for the Liberty Config LS jars:
image

File libertyServerPath = new File(descriptor.getPluginPath().toFile(), "lib/server/liberty-langserver-1.0-SNAPSHOT-jar-with-dependencies.jar");

@kathrynkodama kathrynkodama added the language client language server integration label Nov 25, 2022
@TrevCraw TrevCraw added this to the GA milestone Jan 16, 2023
@TrevCraw TrevCraw added low priority 1 Estimated story points labels Jan 31, 2023
@TrevCraw TrevCraw added the enhancement New feature or request label Jul 24, 2023
dessina-devasia added a commit to dessina-devasia/liberty-tools-intellij that referenced this issue Sep 5, 2023
dessina-devasia added a commit that referenced this issue Sep 11, 2023
…_jar_version

Fixes #173: Updated the regex to strip the Libery Config LS jars version
TrevCraw pushed a commit to TrevCraw/liberty-tools-intellij that referenced this issue Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Estimated story points enhancement New feature or request language client language server integration low priority
Projects
Status: 23.0.12
3 participants