Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post process schema #206

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

cherylking
Copy link
Member

@cherylking cherylking commented Aug 25, 2023

Fixes #186

This PR updates the default cached schema to remove the anyAttribute from elements without extraProperties. It also does the same post processing on generated schema files for local Liberty installations and Liberty running in containers.

Here is the before (no diagnostic on the bogus attribute):

Screenshot 2023-08-25 at 2 01 22 PM

And the after:

Screenshot 2023-08-25 at 2 07 06 PM

@cherylking cherylking requested a review from dshimo August 25, 2023 19:59
@cherylking
Copy link
Member Author

Since git won't show the diff for the xsd file, I am including a couple screenshots of a diff in VS Code. You can see it is a lot of formatting differences and explicit end elements instead of /> on the element itself. The second screenshot shows an example of the anyAttribute removal.

Screenshot 2023-08-25 at 3 03 59 PM

Screenshot 2023-08-25 at 3 06 48 PM

@cherylking cherylking merged commit e116770 into OpenLiberty:4q2023 Aug 25, 2023
4 checks passed
dshimo pushed a commit that referenced this pull request Aug 28, 2023
* remove anyAttribute from default and generated xsds if no extraProperties

* Update cached schema
dshimo pushed a commit that referenced this pull request Aug 31, 2023
* remove anyAttribute from default and generated xsds if no extraProperties

* Update cached schema
dshimo pushed a commit that referenced this pull request Oct 10, 2023
* remove anyAttribute from default and generated xsds if no extraProperties

* Update cached schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants