Improve the way to copy postgres library #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge staging to prod - Add add-pr-to-project.yml
|
This looks good. So in this approach you don't even worry about copying the PostgreSQL driver during just a It adds a bit of complexity to the Dockerfile instead with the second stage, but simplifies the POM. If someone wanted to use a different base image to do the mvn copy they could easily switch that out. |
Mention Dockerfile in the guide
Update pom.xml
Ruilin-Ma
approved these changes
Mar 7, 2024
gkwan-ibm
added a commit
that referenced
this pull request
Mar 7, 2024
Merge staging to prod - Improve the way to copy postgres library (#54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresss issue #41