Integrate dev mode with the Boost plugin #530
Conversation
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Outdated
Show resolved
Hide resolved
awisniew90
force-pushed
the
boost_dev_proto
branch
2 times, most recently
from
499c759
to
e214c56
Compare
| File pomFile = new File(project.getFile().getAbsolutePath()); | ||
| ProjectBuildingResult build = mavenProjectBuilder.build(pomFile, | ||
| session.getProjectBuildingRequest().setResolveDependencies(true)); | ||
| boostProject = build.getProject(); |
There was a problem hiding this comment.
So how/why this is different from the non-Boost path using DevMojo.loadProject(File) to reload the POM? Is it mainly because we're trying to fluff up objects needed by the mojo executor? Some other reason?
There was a problem hiding this comment.
Right - we are passing an actual maven project object to Boost via the mojo executor, so we need that project to have all of its dependency information resolved (i.e. versions when boms are being used). DevMojo.loadProject(File) does not do that, which is ok for that path because it uses an artifact resolver later on to resolve each individual dependency. For our case, we need to use the MavenProjectBuilder which builds a new maven project object with dependency versions correctly resolved.
|
One thing that stands out to me is that we are using the presence of the Boost plugin in the MavenProject in order to decide whether or not we should run the boost mojos. Does this still work if we are invoking Boost dev mode directly from the command line without defining it in the pom? |
Not sure what you mean by "invoking Boost dev mode directly"... we don't have a 'dev' goal in Boost, only in LMP. |
|
Appveyor is failing with several compilation errors which seem unrelated to this change. Are these known issues? |
awisniew90
force-pushed
the
boost_dev_proto
branch
from
e214c56
to
61ad497
Compare
Haven't looked at past builds but I see:
which, with the fact that it's running on Windows, seems suspiciously like an environmental issue. |
|
I have not seen compilation errors in AppVeyor, but I do see this in many recent builds (also seems like an environment issue):
|
|
I rebased and the compilation failures are resolved now, but there is one failing test only on OL 19.0.0.3. I don't see this failure locally. Might just be a fluke, but am looking into it. |
A boost user will be able to directly call Liberty dev mode via:
mvn io.openliberty.tools:liberty-maven-plugin:3.1.M1-SNAPSHOT:dev(for example)If the Boost plugin is defined in the pom, Liberty dev mode will call
boost:packagewhen changes to the pom are made.