Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for versionless install #1829

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cbridgha
Copy link
Member

No description provided.

Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good to me. The *Test.java files for the failing tests (with invoker.properties) will never be run though right (as we discussed in Slack). So why include them? If it is to document the expected behavior, maybe you should add a comment to them that explains they won't get run, but the build.log should contain the failure if inspected after the test is run?

One final thought...we have a postBuildHookScript cleanTest.bsh that is run after every test. Could some logic be added to that to check if the test was this specific one then look for the expected message in the build.log file (before running the clean command obviously)?

@cherylking
Copy link
Member

One more thing...I think the new test case modules need to be added to the pom.xml in kernel-install-feature-test. And you may be able to add a specific postBuildHookScript in that pom.xml for the maven-invoker-plugin that would just apply to these tests.

@cbridgha
Copy link
Member Author

I like your idea for postBuild. will try

@cherylking
Copy link
Member

I think we are going to need to move the negative tests out of kernel-install-feature-test into their own test buckets since those are all invoked as part of that bucket. I don't think the invoker.properties are being honored when called as sub-modules of that larger bucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants